BUG: resample.agg with read-only data #32758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/series.py
Outdated
| # check for is_list_like/slice instead of is_scalar to allow non-standard | ||
| # scalars through, e.g. cftime.datetime needed by xarray | ||
| # https://github.com/pydata/xarray/issues/3751 | ||
| key_is_scalar = not is_list_like(key) and not isinstance(key, slice) |
There was a problem hiding this comment.
This sneaked in from a different issue / pr?
There was a problem hiding this comment.
looks like it, will revert, thanks
WillAyd
reviewed
Mar 16, 2020
| @cython.wraparound(False) | ||
| @cython.boundscheck(False) | ||
| def group_last(rank_t[:, :] out, | ||
| int64_t[:] counts, | ||
| rank_t[:, :] values, | ||
| ndarray[rank_t, ndim=2] values, |
There was a problem hiding this comment.
Does this limitation really apply to any place where we are using memoryviews? Or just isolated to this?
There was a problem hiding this comment.
my understanding is that it applies to memoryviews with fused types
|
thanks @jbrockmendel |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 17, 2020
|
Just a heads up I think this introduced some new build warnings. I've had a separate PR to clean those up and error going forward so can fall back to that if required, but if you have time to look in the interim would be appreciated as well Here is what I see pandas/_libs/groupby.c:37458:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:38233:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:39008:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:39781:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:40563:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:41999:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:42820:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:43641:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:44460:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:45288:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/hashtable.c:63216:20: warning: unused function '__pyx_memview_get_object' [-Wunused-function]
static PyObject *__pyx_memview_get_object(const char *itemp) {
^
pandas/_libs/hashtable.c:63221:12: warning: unused function '__pyx_memview_set_object' [-Wunused-function]
static int __pyx_memview_set_object(const char *itemp, PyObject *obj) {
^
pandas/_libs/groupby.c:55168:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:55970:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:56772:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:57568:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:58985:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:59784:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:60583:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~
pandas/_libs/groupby.c:61376:30: warning: comparison of integers of different signs: 'Py_ssize_t' (aka 'long') and
'size_t' (aka 'unsigned long') [-Wsign-compare]
__pyx_t_3 = ((!((__pyx_t_2 == __pyx_t_1) != 0)) != 0);
~~~~~~~~~ ^ ~~~~~~~~~ |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Mar 17, 2020
Co-authored-by: jbrockmendel <[email protected]>
|
@WillAyd where does this sit on the annoyance-problem scale? i.e. is waiting for cython 0.30 a viable option? |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff